"Dr. David Alan Gilbert (git)" <dgilb...@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
>
> Peter reported a lock error on MacOS after my a82d593b
> patch.
>
> migrate_get_current does one-time initialisation of
> a bunch of variables.
> migrate_init does reinitialisation even on a 2nd
> migrate after a cancel.
>
> The problem here was that I'd initialised the mutex
> in migrate_get_current, and the memset in migrate_init
> corrupted it.
>
> Remove the memset and replace it by explicit initialisation
> of fields that need initialising; this also turns out to be simpler
> than the old code that had to preserve some fields.
>
> Reported-by: Peter Maydell <peter.mayd...@linaro.org>
> Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> Fixes: a82d593b

Reviewed-by: Juan Quintela <quint...@redhat.com>

Applied

Reply via email to