On Mon, 11/09 23:39, Max Reitz wrote: > All error paths after a successful bdrv_open() of target_bs should > contain a bdrv_unref(target_bs). This one did not yet, so add it. > > Signed-off-by: Max Reitz <mre...@redhat.com> > Reviewed-by: Alberto Garcia <be...@igalia.com> > Reviewed-by: Kevin Wolf <kw...@redhat.com> > --- > blockdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/blockdev.c b/blockdev.c > index 8607df9..3185808 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -2914,6 +2914,7 @@ void qmp_drive_backup(const char *device, const char > *target, > bmap = bdrv_find_dirty_bitmap(bs, bitmap); > if (!bmap) { > error_setg(errp, "Bitmap '%s' could not be found", bitmap); > + bdrv_unref(target_bs); > goto out; > } > } > -- > 2.6.2 > >
Reviewed-by: Fam Zheng <f...@redhat.com>