I noticed that introspection was not documenting either qmp_capabilities nor the ErrorClass enum. I think this is worth fixing for 2.5 when introspection is brand new, so that if we later extend the ErrorClass enum or add future capability negotiation (and in particular if such additions get backported in downstream builds), a client will be able to use introspection to learn whether the new features are supported, regardless of the qemu version.
Note that this also adds qmp_capabilities to 'query-commands'. Yes, this is borderline, and you may decide that it doesn't deserve to be called a bug and should wait for 2.6. Eric Blake (3): qapi: Add type.is_empty() helper qapi: Fix command with named empty argument type qapi: Expose ErrorClass through introspection Marc-André Lureau (1): monitor: use qapi for qmp_capabilities command docs/qmp-spec.txt | 16 ++++++++++++++++ monitor.c | 8 ++++++-- qapi-schema.json | 32 ++++++++++++++++++++++++++++++++ qmp-commands.hx | 4 ++-- scripts/qapi-commands.py | 6 +++--- scripts/qapi-event.py | 6 +++--- scripts/qapi-types.py | 2 +- scripts/qapi.py | 3 +++ tests/qapi-schema/qapi-schema-test.json | 2 ++ tests/qapi-schema/qapi-schema-test.out | 2 ++ tests/test-qmp-commands.c | 5 +++++ 11 files changed, 75 insertions(+), 11 deletions(-) -- 2.4.3
