On 05/11/2015 19:15, Peter Maydell wrote: > + > + /* This is a softmmu CPU object, so create a property for it > + * so users can wire up its memory. (This can't go in qom/cpu.c > + * because that file is compiled only once for both user-mode > + * and system builds.) The default if no link is set up is to use > + * the system address space. > + */ > + object_property_add_link(OBJECT(cpu), "memory", TYPE_MEMORY_REGION, > + (Object **)&cpu->memory, > + qdev_prop_allow_set_link_before_realize, > + OBJ_PROP_LINK_UNREF_ON_RELEASE, > + &error_abort); > + cpu->memory = system_memory;
You need object_ref(cpu->memory) here, because setting cpu->memory will drop a reference from the previously-set value. Paolo > #endif
