Eric Blake <ebl...@redhat.com> writes: > By moving err into data, we can let test teardown take care > of cleaning up any collected error; it also gives us fewer > lines of code between repeated tests where init runs teardown > on our behalf.
I think this paragraph is no longer valid: you aren't moving err anywhere in this version. > Rather than duplicate code between .c files, I added a new > test-qmp-common.h. I debated about putting > error_free_or_abort() in error.h, but it seems like something > that is only useful for tests. Maybe, maybe not. I'd accept it into error.h. > Signed-off-by: Eric Blake <ebl...@redhat.com> Patch looks okay.
