On Thu, Nov 05, 2015 at 07:26:50AM +0100, Greg Kurz wrote: > On Wed, 4 Nov 2015 20:19:32 +0300 > > + * > > + * Returned block driver will be always locked. > > + */ > > + > > +bool bdrv_all_can_snapshot(BlockDriverState **first_bad_bs) > > Juan suggested bdrv_snapshot_is_possible() and FWIW you already emphasize > that it involves all block drivers in the above comment.
I like the "all" in the function name. There is a set of bdrv_*_all() functions that operate on all BlockDriverStates. What these functions have in common is that they acquire AioContext. Other bdrv_*() functions don't do this, so the naming helps make the semantics clear.
signature.asc
Description: PGP signature