Gerd Hoffmann <kra...@redhat.com> writes: >> +#include <sys/inotify.h> > > What happens on non-linux systems? > > I guess we need some #ifdefs to not break the build there, or enable mtp > only for CONFIG_LINUX=y instead of CONFIG_POSIX=y.
Oh, I had the ifdefs but somehow I confused myself by thinking CONFIG_POSIX is enough not to compile on non-linux systems. I guess I was only thinking about Windows. I will add them back. >> +enum inotify_event_type { >> + CREATE = 1, >> + DELETE = 2, >> + MODIFY = 3, >> +}; > > Patch #3 removes this, I'd suggest to extent "enum mtp_code" with the > event codes here so we don't need this temporary thing. Ok. > cheers, > Gerd