On 11/04/2015 12:49 PM, Juan Quintela wrote:
void hmp_delvm(Monitor *mon, const QDict *qdict) { const char *name = qdict_get_str(qdict, "name");if (!bdrv_find_snapshot_bs()) { monitor_printf(mon, "No block device supports snapshots\n"); return; } del_existing_snapshots(mon, name); } Yes, we have changed the semantics "slightly". Pervious version of hmp_delvm() will try to remove all the snapshots from any device with that name. This one would remove them until it finds one error. I think that the code reuse and the consistence trumps the change in semantics (really the change is only on error cases).
I think you are wrong here. You can not abort operation if one disk does not have a snapshot assuming the following situation - VM has one disk - snapshot XXX is made - 2nd disk is added - remove XXX snapshot Your position is understood. I'll send yet another proof of concept in an hour. Den
