Re: [Qemu-devel] [PATCH v10 08/14] blockjob: Simplify block_job_finish_sync

[Stefan Hajnoczi]

On Fri, Oct 23, 2015 at 07:56:46PM -0400, John Snow wrote:
> +    block_job_ref(job);
>      finish(job, &local_err);
>      if (local_err) {
>          error_propagate(errp, local_err);
>          return -EBUSY;

Refcount leak, missing block_job_unref(job).

signature.asc
Description: PGP signature