On 11/02/2015 07:38 AM, Laszlo Ersek wrote: > > (1) Can you please split this patch in two? Maybe I'm just particularly > slow today, but I feel that it would help me review this patch if I > could look at each .read conversion in separation. I'd like to see that > each conversion, individually, is unobservable from the guest. > > The first patch would introduce the new function and convert one of the > callbacks. The second patch would convert the other callback and remove > the old function. (Un-called static functions would break the compile, > so the removal cannot be left for a third patch.)
You can mark static functions with __attribute__((__unused__)), and gcc will then let you leave them for a later cleanup patch. I'm not sure if clang behaves similarly, though. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
