Eric Blake <ebl...@redhat.com> writes: > On 10/22/2015 08:26 AM, Eric Blake wrote: > >>> PATCH 08-15 appear to be a purely mechanical switch to u. and from kind >>> to type, except for a qapi.py hunk that looks like it should be in PATCH >>> 07, and a comment update to tests/qapi-schema/union-clash-type.json. >>> Did I miss anything? >>> >>> Combined diffstat isn't so bad: >>> >>> 36 files changed, 393 insertions(+), 394 deletions(-) >> >> It already needs a rebase; some of Dan's work has caused more changes to >> ui/vnc.c and util/qemu-sockets.c. So hopefully I post v10 soon. >> >>> >>> I've seen worse tree-wide changes, some of them my own. I'd be tempted >>> to squash the complete switch together. But squashing is easy, so we >>> can keep it separate while we review, and decide when we're done. >> >> Sure, v10 will keep things separate, but squashing won't hurt too much. >> After all, v5 had it all as one patch. > > Just so I'm clear, if we wanted to squash, would it be just 8-15 (just > the mechanical changes, but keeping the front-end scaffolding hack and > backend cleanup, and keeping non-mechanical changes split off of 7 and 8 > as a separate patch), or the entire 7-16 (no hack at all, and nothing to > split off of 7 and 8)?
Either way could work.
