On 21/10/2015 17:01, Peter Maydell wrote: > On 16 October 2015 at 00:52, Yongbok Kim <yongbok....@imgtec.com> wrote: >> Add support of MIPS GIC. >> >> hw/mips/Makefile.objs | 2 +- >> hw/mips/mips_gcr.c | 120 ++++++++ >> hw/mips/mips_gcr.h | 57 ++++ >> hw/mips/mips_gic.c | 653 >> ++++++++++++++++++++++++++++++++++++++++++ >> hw/mips/mips_gic.h | 298 +++++++++++++++++++ >> hw/mips/mips_malta.c | 71 +++++- >> target-mips/cpu.h | 4 +- >> target-mips/translate.c | 17 ++ >> target-mips/translate_init.c | 3 +- >> 9 files changed, 1220 insertions(+), 5 deletions(-) >> create mode 100644 hw/mips/mips_gcr.c >> create mode 100644 hw/mips/mips_gcr.h >> create mode 100644 hw/mips/mips_gic.c >> create mode 100644 hw/mips/mips_gic.h > > Should this live in hw/intc/ if it is an interrupt controller? > > thanks > -- PMM >
Actually I have considered that but I just hesitated to put the files in the hw/intc as all other MIPS related hw component files are in hw/mips. I agree with your opinion. From the v2 the mips_gic.{c|h} files will be in the directory. I think the mips_gcr.{c|h} is quite MIPS specific and it doesn't fit into any other directory than hw/mips. Regards, Yongbok