On 10/18/2015 03:53 PM, Leonid Bloch wrote: > This series fixes several issues with incorrect packet/octet counting in > e1000's Statistic registers, fixes a bug in the packet address filtering > procedure, and implements many MAC registers that were absent before. > Additionally, some cosmetic changes are made. > > Leonid Bloch (6): > e1000: Cosmetic and alignment fixes > e1000: Trivial implementation of various MAC registers > e1000: Fixing the received/transmitted packets' counters > e1000: Fixing the received/transmitted octets' counters > e1000: Fixing the packet address filtering procedure > e1000: Implementing various counters > > hw/net/e1000.c | 313 > ++++++++++++++++++++++++++++++++++++++-------------- > hw/net/e1000_regs.h | 8 +- > 2 files changed, 236 insertions(+), 85 deletions(-) >
Looks good to me overall, just few comments in individual patches. A question here, is there any real user/OSes that tries to use those registers? If not, maintain them sees a burden and it's a little bit hard the test them unless unit-test were implemented for those registers. And I'd like to know the test status of this series. At least both windows and linux guest need to be tested. Thanks
