On 12.10.2015 11:16, Alberto Garcia wrote: > The 'snapshot-node-name' parameter of blockdev-snapshot-sync allows > setting the node name of the image that is going to be created. > > Before creating the image, external_snapshot_prepare() checks that the > name is not already being used. The check is however incomplete since > it only considers existing node names, but node names must not clash > with device IDs either because they share the same namespace. > > If the user attempts to create a snapshot using the name of an > existing device for the 'snapshot-node-name' parameter the operation > will eventually fail, but only after the new image has been created. > > This patch replaces bdrv_find_node() with bdrv_lookup_bs() to extend > the check to existing device IDs, and thus detect possible name > clashes before the new image is created. > > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > blockdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
