Eric Blake <ebl...@redhat.com> writes:
> On 10/07/2015 10:38 AM, Markus Armbruster wrote:
>> Eric Blake <ebl...@redhat.com> writes:
>>
>>> Commit ac88219a had several TODO markers about whether we needed
>>> to automatically create the corresponding array type alongside
>>> any other type. It turns out that most of the time, we don't!
>>>
>
>>> + def _make_simple_variant(self, case, typ, info):
>>> if isinstance(typ, list):
>>> assert len(typ) == 1
>>> - typ = self._make_array_type(typ[0])
>>> - typ = self._make_implicit_object_type(typ, 'wrapper',
>>> - [self._make_member('data',
>>> typ)])
>>> + typ = self._make_array_type(typ[0], info)
>>> + typ = self._make_implicit_object_type(
>>> + typ, 'wrapper', [self._make_member('data', typ, info)])
>>
>> I'd indent the hanging intent a bit more, to make the = stand out.
>
> pep8 doesn't like it:
>
> scripts/qapi.py:1299:17: E126 continuation line over-indented for
> hanging indent
Meh.
See also https://github.com/PyCQA/pep8/issues/167
> but it was okay with:
>
> type = (self._make_implicit_object_type(
> type, ...))
>
> and that does look a little better.
I find it a bit stilted. Let's stick with your first version.
