On Thu, Oct 8, 2015 at 6:24 PM, Michael Davidsaver <mdavidsa...@gmail.com> wrote: > On 10/08/2015 04:09 PM, Peter Crosthwaite wrote: >> On Thu, Oct 8, 2015 at 8:40 AM, Michael Davidsaver >> <mdavidsa...@gmail.com> wrote: >>> Implement the SYSRESETREQ bit of the AIRCR register >>> for armv7-m (ie. cortex-m3). >>> >> >> This would serve better as the commit message to the patch (which I >> notice is missing a commit blurb). > > Does this warrant sending an updated patch? I would have no objection to > whomever applies the patch simply changing the commit message. >
I would resend as a single. But I am yet to get around to a proper review of the patch proper, as I need to dig out relavent docs. So if you want a day or two I might have more comments. Regards, Peter >>> A small patch to see if I have the submission process figured out. >>> >> >> It is usual for the cover and patches to be enumerated together with >> the cover being patch 0, e.g. the subject would read [PATCH 0/1]. the >> --cover-letter switch of git format-patch does this for you. > > Alas in this case it did not. Probably because I omitted '--numbered'. > >>> Michael Davidsaver (1): >> >> When sending a single, a cover is not required. You could just send >> the patch on it's own. This will all be useful when you come to send >> multi-patch series however. > > Noted. > > Thanks for the feedback Peter. > > > Michael
