On 8 October 2015 at 14:02, Markus Armbruster <arm...@redhat.com> wrote: > QMP command device-list-properties regressed in 2.1: it can crash or > leave dangling pointers behind. > > -device FOO,help regressed in 2.2: it no longer works for > non-pluggable devices. I tried to fix that some time ago[*], but my > fix failed review. This is my second, more comprehensive try. > > PATCH 1-4 fix two classes of bugs involved in the regressions, PATCH > 5-6 are libqtest preliminaries, PATCH 7 adds tests to demonstrate the > remaining bugs, PATCH 8-10 fix them to a degree (see PATCH 8 for > limitations), and PATCH 11 cleans up. > > v2: > * PATCH 01: new > * PATCH 08,10: Drop all changes for devices "sclp" and > "s390-sclp-event-facility", because they've been fixed in master > > The following changes since commit fb6345f452ba7cefb395389abb17d0af0e42c54b: > > Merge remote-tracking branch 'remotes/ehabkost/tags/numa-pull-request' into > staging (2015-10-08 11:28:17 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-08 > > for you to fetch changes up to 62ddbd770b583ee98fe648c19ea2ec5e0625fe4a: > > Revert "qdev: Use qdev_get_device_class() for -device <type>,help" > (2015-10-08 14:36:36 +0200) > > ---------------------------------------------------------------- > Fix device introspection regressions
Hi. I'm afraid this fails to build for Windows: In file included from /home/petmay01/linaro/qemu-for-merges/hw/input/virtio-input.c:13: /home/petmay01/linaro/qemu-for-merges/include/standard-headers/linux/input.h:890:1: error: "SW_MAX" redefined In file included from /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/windows.h:55, from /home/petmay01/linaro/qemu-for-merges/include/sysemu/os-win32.h:29, from /home/petmay01/linaro/qemu-for-merges/include/qemu/osdep.h:65, from /home/petmay01/linaro/qemu-for-merges/include/qemu-common.h:15, from /home/petmay01/linaro/qemu-for-merges/include/qemu/iov.h:17, from /home/petmay01/linaro/qemu-for-merges/hw/input/virtio-input.c:7: /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/winuser.h:729:1: error: this is the location of the previous definition thanks -- PMM