On Thu 17 Sep 2015 03:48:07 PM CEST, Kevin Wolf wrote: > @@ -151,7 +151,7 @@ static void blkverify_close(BlockDriverState *bs) > { > BDRVBlkverifyState *s = bs->opaque; > > - bdrv_unref(s->test_file); > + bdrv_unref_child(bs, s->test_file); > s->test_file = NULL; > }
You are using bdrv_unref_child() here whereas in quorum you kept bdrv_unref(). In principle both seem correct because if you don't detach the children in the driver's close function then bdrv_close() will take care of doing it, but is there a reason why you are using different methods? Berto