A few nits that missed my first review: On 23/09/2015 11:59, Daniel P. Berrange wrote: > +A further complication for the system and userspace emulator binaries is > +that two separate binaries need to be generated.
A further complication for the system emulator binaries (Windows does not support userspace emulation) is that... > There are no > +corresponding $(QEMU_LIBS)/$(QEMU_LDFLAGS) variables, instead there are > +a couple of more targeted variables. The corresponding variable for linker flags is $(LIBS), but usually more targeted variables are used instead. > $(libs_softmmu) is used for > +libraries that must be linked to system emulator targets, $(libs_tools) $(LIBS_TOOLS) > +is used for tools like qemu-img, qemu-nbd, etc and $(libs_qga) is used $(LIBS_QGA) > +for the QEMU guest agent. There is currently no variable for the > +userspace emulator targets. ; they only use the generic $(LIBS) variable. Paolo
