On 09/18/2015 06:00 AM, Markus Armbruster wrote: > Broken in commit f4eb32b "qmp: show QOM properties in > device-list-properties", v2.1. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > qmp.c | 6 ++++++ > tests/device-introspect-test.c | 11 ++++------- > 2 files changed, 10 insertions(+), 7 deletions(-) >
> +++ b/tests/device-introspect-test.c
> @@ -45,13 +45,10 @@ static void test_one_device(const char *type)
> QDict *resp;
> char *help;
>
> - /* FIXME device-list-properties crashes for abstract device, skip */
> - if (strcmp(type, "device")) {
Ah, this answers part of my confusion on 3/7. I was looking for so
condition on 'abstract', but the skip was based on a condition on
'device' (which happens to be abstract). Don't know if a different
wording on that comment would help; maybe:
FIXME device-list-properties crashes for device, because it is abstract;
skip
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
