Re: [Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86

[Gerd Hoffmann]

  Hi,

> -    fw_cfg = fw_cfg_init_io(BIOS_CFG_IOPORT);
> +    fw_cfg = fw_cfg_init_io_dma(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 4, as);

> +    as = g_malloc(sizeof(*as));
> +    address_space_init(as, ram_below_4g, "pc.as");
> +    fw_cfg = bochs_bios_init(as);

I think we can use address_space_memory on x86 too (and can remove the
AddressSpace argument to fw_cfg_init_io_dma).

Otherwise the series looks fine to me (and thanks for picking it up).

cheers,
  Gerd