On 09/17/2015 10:32 AM, Paolo Bonzini wrote: >>>> Can we revert this one, please? Checkpatch now warns about constructs >>>> like >>>> typedef struct MyDevice { >>>> DeviceState parent; >>>> >>>> int reg0, reg1, reg2; >>>> } MyDevice; >>> >>> It's interesting that qom/object.h documents this and start like: >>> >>> typedef struct ObjectClass ObjectClass;
> I think it varies depending on the maintainer. PPC, USB, SCSI, ACPI all > use a separate typedef. I'll prepare a revert. And qapi is about to switch from inline to separate: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04291.html -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature