Eric Blake <ebl...@redhat.com> writes: > On 09/16/2015 05:06 AM, Markus Armbruster wrote: >> The QAPI code generators work with a syntax tree (nested dictionaries) >> plus a few symbol tables (also dictionaries) on the side. > >> Nothing uses the new intermediate representation just yet, thus no >> change to generated files. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- > > >> +class QAPISchemaEnumType(QAPISchemaType): >> + def __init__(self, name, info, values, prefix): >> + QAPISchemaType.__init__(self, name, info) >> + for v in values: >> + assert isinstance(v, str) >> + self.values = values >> + self.prefix = prefix > > Missing: > assert prefix is None or isinstance(prefix, str)
Yes. > Should this be self._prefix, since no clients ever directly use the > member field (they just use the string passed through the visitor)? Yes. If nothing else comes up in review, I'll touch this up on commit. > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks!
