On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lur...@redhat.com>
>
> The common version correctly checks for 0 value case.
>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> hw/misc/ivshmem.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index e391396..f40bc98 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -117,10 +117,6 @@ static inline uint32_t ivshmem_has_feature(IVShmemState
> *ivs,
> return (ivs->features & (1 << feature));
> }
>
> -static inline bool is_power_of_two(uint64_t x) {
> - return (x & (x - 1)) == 0;
> -}
> -
> /* accessing registers - based on rtl8139 */
> static void ivshmem_update_irq(IVShmemState *s)
> {
> @@ -630,7 +626,7 @@ static uint64_t ivshmem_get_size(IVShmemState * s, Error
> **errp) {
> }
>
> /* BARs must be a power of 2 */
> - if (!is_power_of_two(value)) {
> + if (!is_power_of_2(value)) {
> error_setg(errp, "size must be power of 2");
> return 0;
> }
>
Reviewed-by: Claudio Fontana <claudio.font...@huawei.com>
