On 09/14/2015 11:37 PM, Kevin Wolf wrote: > Am 10.09.2015 um 11:55 hat Wen Congyang geschrieben: >> +## >> +# @x-child-add >> +# >> +# Add a new child to the parent BDS. Currently only the Quorum driver >> +# implements this feature. This is useful to fix a broken quorum child. >> +# >> +# @parent: graph node name or id which the child will be added to. >> +# >> +# @child: graph node name that will be added. >> +# >> +# Note: this command is experimental, and not a stable API. >> +# >> +# Since: 2.5 >> +## >> +{ 'command': 'x-child-add', >> + 'data' : { 'parent': 'str', 'child': 'str' } } > > This is probably not future-proof and only made for the special case of > quorum. Specifically, one thing I'm missing is some way to specfiy what > kind of child the new node is when a node can take different types of > children (e.g. bs->file and bs->backing_hd).
Currently, we only add/remove quorum's child. We can add a new parameter to specify the type in the furture to support more things. Thanks Wen Congyang > > Kevin > . >