On Thu, Sep 10, 2015 at 04:11:02PM -0500, Michael Roth wrote: > Certain methods in sPAPRDRConnector objects are only ever called by > RTAS and in many cases are responsible for the logic that determines > the RTAS return codes. > > Rather than having a level of indirection requiring RTAS code to > re-interpret return values from such methods to determine the > appropriate return code, just pass them through directly. > > This requires changing method return types to uint32_t to match the > type of values currently passed to RTAS helpers. > > In the case of read accesses like drc->entity_sense() where we weren't > previously reporting any errors, just the read value, we modify the > function to return RTAS return code, and pass the read value back via > reference. > > Suggested-by: Bharata B Rao <bhar...@linux.vnet.ibm.com> > Suggested-by: David Gibson <da...@gibson.dropbear.id.au> > Cc: qemu-...@nongnu.org > Cc: David Gibson <da...@gibson.dropbear.id.au> > Cc: Bharata B Rao <bhar...@linux.vnet.ibm.com> > Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com>
Series applied to spapr-dev, thanks. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
pgpCrGD2527j4.pgp
Description: PGP signature