On 09/09/2015 08:06, Fam Zheng wrote: > This patch will probably go in before aio_disable_clients,
Actually I think it's blocked by aio_disable_clients. > if any, but I'm not > quite confident about the interface yet: listing a precise set of clients from > monitor is an ugly coupling between modules: > > aio_disable_clients(bdrv_get_aio_context(bs), > AIO_CLIENT_NBD | AIO_CLIENT_IOEVENTFD | > AIO_CLIENT_FOO); > > ... > > aio_enble_clients(bdrv_get_aio_context(bs), > AIO_CLIENT_NBD | AIO_CLIENT_IOEVENTFD | AIO_CLIENT_FOO); > > I prefer at least an abstraction: > > bdrv_quiesce_begin(bs); > > ... > > bdrv_quiesce_end(bs); That's fine. Paolo > My point is maybe we should leave documenting this to whichever series that > introduces it?
