From: Marc-André Lureau <marcandre.lur...@redhat.com>
Check that SLAVE_FD & SHUTDOWN message work and that the master
asked for the ring read status.
Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
---
tests/Makefile | 2 +-
tests/vhost-user-test.c | 168 ++++++++++++++++++++++++++++++++++++++++++++----
2 files changed, 155 insertions(+), 15 deletions(-)
diff --git a/tests/Makefile b/tests/Makefile
index 34c6136..740542c 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -412,7 +412,7 @@ tests/usb-hcd-uhci-test$(EXESUF): tests/usb-hcd-uhci-test.o
$(libqos-usb-obj-y)
tests/usb-hcd-ehci-test$(EXESUF): tests/usb-hcd-ehci-test.o $(libqos-usb-obj-y)
tests/usb-hcd-xhci-test$(EXESUF): tests/usb-hcd-xhci-test.o $(libqos-usb-obj-y)
tests/pc-cpu-test$(EXESUF): tests/pc-cpu-test.o
-tests/vhost-user-test$(EXESUF): tests/vhost-user-test.o qemu-char.o
qemu-timer.o $(qtest-obj-y)
+tests/vhost-user-test$(EXESUF): tests/vhost-user-test.o qemu-char.o
qemu-timer.o $(qtest-obj-y) $(libqos-pc-obj-y) $(libqos-virtio-obj-y)
tests/qemu-iotests/socket_scm_helper$(EXESUF):
tests/qemu-iotests/socket_scm_helper.o
tests/test-qemu-opts$(EXESUF): tests/test-qemu-opts.o libqemuutil.a
libqemustub.a
tests/test-write-threshold$(EXESUF): tests/test-write-threshold.o
$(block-obj-y) libqemuutil.a libqemustub.a
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index f78483d..dba50c0 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-test.c
@@ -21,6 +21,12 @@
#include <sys/mman.h>
#include <sys/vfs.h>
#include <qemu/sockets.h>
+#include "libqos/pci-pc.h"
+#include "libqos/virtio.h"
+#include "libqos/virtio-pci.h"
+#include "libqos/malloc.h"
+#include "libqos/malloc-pc.h"
+#include "libqos/malloc-generic.h"
/* GLIB version compatibility flags */
#if !GLIB_CHECK_VERSION(2, 26, 0)
@@ -40,12 +46,12 @@
#define QEMU_CMD_ACCEL " -machine accel=tcg"
#define QEMU_CMD_MEM " -m %d -object memory-backend-file,id=mem,size=%dM,"\
"mem-path=%s,share=on -numa node,memdev=mem"
-#define QEMU_CMD_CHR " -chardev socket,id=%s,path=%s"
+#define QEMU_CMD_CHR " -chardev socket,id=%s,path=%s%s"
#define QEMU_CMD_NETDEV " -netdev vhost-user,id=net0,chardev=%s,vhostforce"
#define QEMU_CMD_NET " -device virtio-net-pci,netdev=net0 "
#define QEMU_CMD_ROM " -option-rom ../pc-bios/pxe-virtio.rom"
-#define QEMU_CMD QEMU_CMD_ACCEL QEMU_CMD_MEM QEMU_CMD_CHR \
+#define QEMU_CMD QEMU_CMD_ACCEL QEMU_CMD_MEM QEMU_CMD_CHR \
QEMU_CMD_NETDEV QEMU_CMD_NET QEMU_CMD_ROM
#define HUGETLBFS_MAGIC 0x958458f6
@@ -56,6 +62,7 @@
#define VHOST_USER_F_PROTOCOL_FEATURES 30
#define VHOST_USER_PROTOCOL_F_LOG_SHMFD 0
+#define VHOST_USER_PROTOCOL_F_SLAVE_REQ 1
#define VHOST_LOG_PAGE 0x1000
@@ -77,9 +84,16 @@ typedef enum VhostUserRequest {
VHOST_USER_SET_VRING_ERR = 14,
VHOST_USER_GET_PROTOCOL_FEATURES = 15,
VHOST_USER_SET_PROTOCOL_FEATURES = 16,
+ VHOST_USER_SET_SLAVE_FD = 17,
VHOST_USER_MAX
} VhostUserRequest;
+typedef enum VhostUserSlaveRequest {
+ VHOST_USER_SLAVE_NONE = 0,
+ VHOST_USER_SLAVE_SHUTDOWN = 1,
+ VHOST_USER_SLAVE_MAX
+} VhostUserSlaveRequest;
+
typedef struct VhostUserMemoryRegion {
uint64_t guest_phys_addr;
uint64_t memory_size;
@@ -118,6 +132,7 @@ static VhostUserMsg m __attribute__ ((unused));
/* The version of the protocol we support */
#define VHOST_USER_VERSION (0x1)
/*****************************************************************************/
+#define VIRTIO_QUEUE_MAX 1024
typedef struct TestServer {
gchar *socket_path;
@@ -129,6 +144,9 @@ typedef struct TestServer {
GMutex *data_mutex;
GCond *data_cond;
int log_fd;
+ int req_fd;
+ int get_base_count;
+ uint16_t set_base[VIRTIO_QUEUE_MAX];
} TestServer;
static const char *hugefs;
@@ -331,7 +349,8 @@ static void chr_read(void *opaque, const uint8_t *buf, int
size)
/* send back features to qemu */
msg.flags |= VHOST_USER_REPLY_MASK;
msg.size = sizeof(m.u64);
- msg.u64 = 1 << VHOST_USER_PROTOCOL_F_LOG_SHMFD;
+ msg.u64 = 1 << VHOST_USER_PROTOCOL_F_LOG_SHMFD |
+ 1 << VHOST_USER_PROTOCOL_F_SLAVE_REQ;
p = (uint8_t *) &msg;
qemu_chr_fe_write_all(chr, p, VHOST_USER_HDR_SIZE + msg.size);
break;
@@ -343,6 +362,11 @@ static void chr_read(void *opaque, const uint8_t *buf, int
size)
msg.state.num = 0;
p = (uint8_t *) &msg;
qemu_chr_fe_write_all(chr, p, VHOST_USER_HDR_SIZE + msg.size);
+ s->get_base_count++;
+ break;
+
+ case VHOST_USER_SET_VRING_BASE:
+ s->set_base[msg.state.index] = msg.state.num;
break;
case VHOST_USER_SET_MEM_TABLE:
@@ -371,6 +395,11 @@ static void chr_read(void *opaque, const uint8_t *buf, int
size)
g_cond_signal(s->data_cond);
break;
+ case VHOST_USER_SET_SLAVE_FD:
+ qemu_chr_fe_get_msgfds(chr, &s->req_fd, 1);
+ g_cond_signal(s->data_cond);
+ break;
+
case VHOST_USER_RESET_OWNER:
s->fds_num = 0;
break;
@@ -382,7 +411,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int
size)
g_mutex_unlock(s->data_mutex);
}
-static TestServer *test_server_new(const gchar *name)
+static TestServer *test_server_new(const gchar *name, const gchar *chr_opt)
{
TestServer *server = g_new0(TestServer, 1);
gchar *chr_path;
@@ -390,7 +419,8 @@ static TestServer *test_server_new(const gchar *name)
server->socket_path = g_strdup_printf("/tmp/vhost-%s-%d.sock",
name, getpid());
- chr_path = g_strdup_printf("unix:%s,server,nowait", server->socket_path);
+ chr_path = g_strdup_printf(chr_opt ?: "unix:%s,server,nowait",
+ server->socket_path);
server->chr_name = g_strdup_printf("chr-%s", name);
server->chr = qemu_chr_new(server->chr_name, chr_path, NULL);
g_free(chr_path);
@@ -402,17 +432,19 @@ static TestServer *test_server_new(const gchar *name)
server->data_cond = _cond_new();
server->log_fd = -1;
+ server->req_fd = -1;
return server;
}
#define GET_QEMU_CMD(s) \
g_strdup_printf(QEMU_CMD, 512, 512, (hugefs), \
- (s)->chr_name, (s)->socket_path, (s)->chr_name)
+ (s)->chr_name, (s)->socket_path, "", (s)->chr_name)
-#define GET_QEMU_CMDE(s, mem, extra, ...) \
- g_strdup_printf(QEMU_CMD extra, (mem), (mem), (hugefs), \
- (s)->chr_name, (s)->socket_path, (s)->chr_name, ##__VA_ARGS__)
+#define GET_QEMU_CMDE(s, mem, chr_opts, extra, ...) \
+ g_strdup_printf(QEMU_CMD extra, (mem), (mem), (hugefs), \
+ (s)->chr_name, (s)->socket_path, (chr_opts), \
+ (s)->chr_name, ##__VA_ARGS__)
static void test_server_free(TestServer *server)
{
@@ -428,6 +460,10 @@ static void test_server_free(TestServer *server)
close(server->log_fd);
}
+ if (server->req_fd != -1) {
+ close(server->req_fd);
+ }
+
unlink(server->socket_path);
g_free(server->socket_path);
@@ -532,8 +568,8 @@ GSourceFuncs test_migrate_source_funcs = {
static void test_migrate(void)
{
- TestServer *s = test_server_new("src");
- TestServer *dest = test_server_new("dest");
+ TestServer *s = test_server_new("src", NULL);
+ TestServer *dest = test_server_new("dest", NULL);
const char *uri = "tcp:127.0.0.1:1234";
QTestState *global = global_qtest, *from, *to;
GSource *source;
@@ -542,7 +578,7 @@ static void test_migrate(void)
guint8 *log;
guint64 size;
- cmd = GET_QEMU_CMDE(s, 2, "");
+ cmd = GET_QEMU_CMDE(s, 2, "", "");
from = qtest_start(cmd);
g_free(cmd);
@@ -550,7 +586,7 @@ static void test_migrate(void)
size = get_log_size(s);
g_assert_cmpint(size, ==, (2 * 1024 * 1024) / (VHOST_LOG_PAGE * 8));
- cmd = GET_QEMU_CMDE(dest, 2, " -incoming %s", uri);
+ cmd = GET_QEMU_CMDE(dest, 2, "", " -incoming %s", uri);
to = qtest_init(cmd);
g_free(cmd);
@@ -609,6 +645,108 @@ static void test_migrate(void)
global_qtest = global;
}
+static void wait_for_req_fd(TestServer *s)
+{
+ gint64 end_time;
+
+ g_mutex_lock(s->data_mutex);
+ end_time = _get_time() + 5 * G_TIME_SPAN_SECOND;
+ while (s->req_fd == -1) {
+ if (!_cond_wait_until(s->data_cond, s->data_mutex, end_time)) {
+ /* timeout has passed */
+ g_assert(s->req_fd != -1);
+ break;
+ }
+ }
+
+ g_mutex_unlock(s->data_mutex);
+}
+
+#define PCI_SLOT 0x04
+
+static QVirtioPCIDevice *virtio_net_pci_init(QPCIBus *bus, int slot)
+{
+ QVirtioPCIDevice *dev;
+
+ dev = qvirtio_pci_device_find(bus, QVIRTIO_NET_DEVICE_ID);
+ g_assert(dev != NULL);
+ g_assert_cmphex(dev->vdev.device_type, ==, QVIRTIO_NET_DEVICE_ID);
+
+ qvirtio_pci_device_enable(dev);
+ qvirtio_reset(&qvirtio_pci, &dev->vdev);
+ qvirtio_set_acknowledge(&qvirtio_pci, &dev->vdev);
+ qvirtio_set_driver(&qvirtio_pci, &dev->vdev);
+
+ return dev;
+}
+
+static void driver_init(const QVirtioBus *bus, QVirtioDevice *dev)
+{
+ uint32_t features;
+
+ features = qvirtio_get_features(bus, dev);
+ features = features & ~(QVIRTIO_F_BAD_FEATURE |
+ QVIRTIO_F_RING_INDIRECT_DESC |
+ QVIRTIO_F_RING_EVENT_IDX);
+ qvirtio_set_features(bus, dev, features);
+
+ qvirtio_set_driver_ok(bus, dev);
+}
+
+static void test_reconnect(void)
+{
+ TestServer *s = test_server_new("src", "unix:%s,reconnect=1");
+ QTestState *global = global_qtest, *from;
+ VhostUserMsg msg = { .request = VHOST_USER_SLAVE_SHUTDOWN };
+ gchar *cmd;
+ int ret;
+ QPCIBus *bus;
+ QVirtioPCIDevice *dev;
+ QGuestAllocator *alloc;
+
+ msg.flags &= ~VHOST_USER_VERSION_MASK;
+ msg.flags |= VHOST_USER_VERSION;
+
+ cmd = GET_QEMU_CMDE(s, 2, ",server", "");
+ from = qtest_start(cmd);
+ wait_for_req_fd(s);
+ g_free(cmd);
+
+ bus = qpci_init_pc();
+ dev = virtio_net_pci_init(bus, PCI_SLOT);
+ alloc = pc_alloc_init();
+ driver_init(&qvirtio_pci, &dev->vdev);
+
+ s->get_base_count = 0;
+ ret = send(s->req_fd, &msg, VHOST_USER_HDR_SIZE, 0);
+ g_assert_cmpint(ret, ==, VHOST_USER_HDR_SIZE);
+ ret = read(s->req_fd, &msg, VHOST_USER_HDR_SIZE);
+ g_assert_cmpint(ret, ==, VHOST_USER_HDR_SIZE);
+ g_assert_cmpint(msg.u64, ==, 0);
+
+ /* check that get_base was called for each queue */
+ g_assert_cmpint(s->get_base_count, ==, 2);
+
+ close(s->req_fd);
+ s->req_fd = -1;
+
+ /* reconnect */
+ qemu_chr_disconnect(s->chr);
+ wait_for_fds(s);
+ /* FIXME: manipulate vring to change last used index */
+ g_assert_cmpint(s->set_base[0], ==, 0);
+ g_assert_cmpint(s->set_base[1], ==, 0);
+ pc_alloc_uninit(alloc);
+ qvirtio_pci_device_disable(dev);
+ g_free(dev);
+ qpci_free_pc(bus);
+
+ qtest_quit(from);
+ test_server_free(s);
+
+ global_qtest = global;
+}
+
static const char *init_hugepagefs(void)
{
const char *path;
@@ -656,18 +794,20 @@ int main(int argc, char **argv)
hugefs = init_hugepagefs();
if (!hugefs) {
+ g_debug("no hugepagefs available, skipping");
return 0;
}
_thread_new(NULL, thread_function, NULL);
- server = test_server_new("test");
+ server = test_server_new("test", NULL);
qemu_cmd = GET_QEMU_CMD(server);
s = qtest_start(qemu_cmd);
g_free(qemu_cmd);
qtest_add_data_func("/vhost-user/read-guest-mem", server, read_guest_mem);
qtest_add_func("/vhost-user/migrate", test_migrate);
+ qtest_add_func("/vhost-user/reconnect", test_reconnect);
ret = g_test_run();
--
2.4.3
