Quoting Paolo Bonzini (2015-09-07 15:39:39) > > > On 07/09/2015 22:37, Michael Roth wrote: > > This kinda does it, although it introduces a circular dependency warning > > on posix (since qemu-ga$(EXESUF) == qemu-ga there, yet qemu-ga has > > a qemu-ga$(EXESUF) dependency. > > > > Could be fixed by making a new 'qemu-guest-agent' do-the-right-thing target, > > but that means new build process for posix and w32 instead of just w32. The > > alternative is to only define the 'qemu-ga' do-the-right-thing target for > > w32 > > (since posix already has such a target). That requires a Makefile ifdef > > MINGW > > or somesuch though, which isn't ideal. I think the latter is worth the > > simplified build process (same as we currently do on posix, but with some > > extra config params) > > Or just "ifneq ($(EXESUF),)".
Thanks, that would work. Also noticed I forget the MSI dependency in previous patch. Will send a proper patch soon. > > Paolo >
