Hi Peter, > -----Original Message----- > From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Sunday, September 06, 2015 12:03 AM > To: Sai Pavan Boddu > Cc: qemu-devel@nongnu.org Developers; Peter Maydell; Alistair Francis; > Edgar Iglesias; Sai Pavan Boddu > Subject: Re: [PATCH V2] sdhci: use PRIx64 for uint64_t type > > On Sat, Sep 5, 2015 at 2:12 AM, Sai Pavan Boddu > <sai.pavan.bo...@xilinx.com> wrote: > > Fix compile time warnings, because of type mismatch for unsigned long > > long type. > > > > Signed-off-by: Sai Pavan Boddu <saip...@xilinx.com> > > Reviewed-by: Peter Crosthwaite <crosthwaite.pe...@gmail.com> [Sai Pavan ] Thanks :), I will even send out V3_2P, closing on Eric comments.
Regards, Sai Pavan > > > --- > > Changes for V2: > > Fix commit message. > > Correct line lenght. > > --- > > hw/sd/sdhci.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c > > index 2469077..639feee 100644 > > --- a/hw/sd/sdhci.c > > +++ b/hw/sd/sdhci.c > > @@ -22,6 +22,7 @@ > > * with this program; if not, see <http://www.gnu.org/licenses/>. > > */ > > > > +#include <inttypes.h> > > #include "hw/hw.h" > > #include "sysemu/block-backend.h" > > #include "sysemu/blockdev.h" > > @@ -719,7 +720,8 @@ static void sdhci_do_adma(SDHCIState *s) > > break; > > case SDHC_ADMA_ATTR_ACT_LINK: /* link to next descriptor table */ > > s->admasysaddr = dscr.addr; > > - DPRINT_L1("ADMA link: admasysaddr=0x%lx\n", s->admasysaddr); > > + DPRINT_L1("ADMA link: admasysaddr=0x%" PRIx64 "\n", > > + s->admasysaddr); > > break; > > default: > > s->admasysaddr += dscr.incr; > > @@ -727,7 +729,8 @@ static void sdhci_do_adma(SDHCIState *s) > > } > > > > if (dscr.attr & SDHC_ADMA_ATTR_INT) { > > - DPRINT_L1("ADMA interrupt: admasysaddr=0x%lx\n", s- > >admasysaddr); > > + DPRINT_L1("ADMA interrupt: admasysaddr=0x%" PRIx64 "\n", > > + s->admasysaddr); > > if (s->norintstsen & SDHC_NISEN_DMA) { > > s->norintsts |= SDHC_NIS_DMA; > > } > > -- > > 1.9.1 > >
