On 09/02/2015 02:51 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang <we...@cn.fujitsu.com> > Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com> > Signed-off-by: Gonglei <arei.gong...@huawei.com> > Cc: Luiz Capitulino <lcapitul...@redhat.com> > Cc: Michael Roth <mdr...@linux.vnet.ibm.com> > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > --- > block.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > include/block/block.h | 5 +++++ > include/block/block_int.h | 14 ++++++++++++++ > qapi/block-core.json | 15 +++++++++++++++ > 4 files changed, 77 insertions(+) >
Just an interface review for now:
> +++ b/qapi/block-core.json
> @@ -1810,6 +1810,21 @@
> 'data': { '*export': 'str' } }
>
> ##
> +# @ReplicationMode
> +#
> +# An enumeration of replication modes.
> +#
> +# @unprotected: Replication is not started or after failover.
Maybe:
Replication is either not started, or has experienced failover.
> +#
> +# @primary: Primary mode, the vm's state will be sent to secondary QEMU.
> +#
> +# @secondary: Secondary mode, receive the vm's state from primary QEMU.
> +#
> +# Since: 2.4
You've missed 2.4; this should be 2.5.
> +##
> +{ 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] }
Where is 'unprotected' in this list?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
