Re: [Qemu-devel] [PATCH] linux-user: use default mmap_min_addr 65536 when /proc/sys/vm/mmap_min_addr cannot be read

[Richard Henderson]

On 05/13/2010 06:17 AM, Martin Jansa wrote:
> @@ -2899,8 +2900,14 @@ int main(int argc, char **argv, char **envp)
>              if (fscanf(fp, "%lu", &tmp) == 1) {
>                  mmap_min_addr = tmp;
>                  qemu_log("host mmap_min_addr=0x%lx\n", mmap_min_addr);
> +            } else {
> +                qemu_log("cannot read value from /proc/sys/vm/mmap_min_addr, 
> assuming %d\n", MMAP_MIN_ADDR_DEFAULT);
> +                mmap_min_addr = MMAP_MIN_ADDR_DEFAULT;
>              }
>              fclose(fp);
> +        } else {
> +            qemu_log("cannot open /proc/sys/vm/mmap_min_addr for reading, 
> assuming %d\n", MMAP_MIN_ADDR_DEFAULT);
> +            mmap_min_addr = MMAP_MIN_ADDR_DEFAULT;
>          }
>      }

Perhaps you can combine these two else clauses?


r~