On Mon, Aug 24, 2015 at 05:42:09PM +0800, Zhu Guihua wrote: > Update cpu_model in MachineState for i386, so that the field can be used > for cpu hotplug, instead of using a static variable. > > Signed-off-by: Zhu Guihua <zhugh.f...@cn.fujitsu.com> [...] > -void pc_cpus_init(const char *cpu_model, DeviceState *icc_bridge) > +void pc_cpus_init(MachineState *machine, DeviceState *icc_bridge)
This is a PC initialization function, so a PCMachineState argument makes more sense. See pc_cmos_init(), load_linux(), pc_guest_info_init(), pc_memory_init(), etc. The rest looks good. -- Eduardo
