On 26/07/2015 22:35, Hervé Poussineau wrote: > + memory_region_init_ram(&s->prom, OBJECT(dev), > + "dp8393x-prom", SONIC_PROM_SIZE, &local_err); > + if (local_err) { > + error_propagate(errp, local_err); > + return; > + } > + memory_region_set_readonly(&s->prom, true);
Yup, this is better. memory_region_init_rom_device is used whenever you want to catch writes and do something about them. For example, flash devices enable ROMD mode, where reads also go down the MMIO path. Paolo