On 20 July 2015 at 19:29, John Snow <js...@redhat.com> wrote: > From: Stefan Fritsch <s...@sfritsch.de> > > The AHCI spec requires that the HBA sets the ICC bits to zero after the > ICC change is done. Since we don't do any ICC change, force the bits to > zero all the time. > > This fixes delays with some OSs (e.g. OpenBSD) waiting for the ICC bits > to change to 0.
This change provokes a lot of clang sanitizer warnings: /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:288:49: runtime error: left shift of 15 by 28 places cannot be represented in type 'int' PORT_CMD_ICC_MASK is defined as #define PORT_CMD_ICC_MASK (0xf << 28) /* i/f ICC state mask */ which shifts into the sign bit of a signed integer. thanks -- PMM