On Tue, Jul 14, 2015 at 04:42:44PM +0800, Chen, Tiejun wrote: > >>>diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h > >>>index 4356af4..703148e 100644 > >>>--- a/include/hw/xen/xen.h > >>>+++ b/include/hw/xen/xen.h > >>>@@ -51,4 +51,5 @@ void xen_register_framebuffer(struct MemoryRegion *mr); > >>> # define HVM_MAX_VCPUS 32 > >>> #endif > >>> > >>>+extern void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t > >>>gpu_dev_id); > >>> #endif /* QEMU_HW_XEN_H */ > >> > >>You are right that I was confused on my previous comment, but it is true > >>that it shouldn't be part of this patch: it should be part of patch > > Right. > > >>7/10. Also the declaration should probably not be in the xen.h header. > >> > >>Michael, where do you think should go? > > > >Donnu - add a header? > > > > What about the include/hw/i386/pc.h file? > > Thanks > Tiejun
Somewhat ugly, but OK I guess.
