On Thu, Jul 9, 2015 at 5:51 PM, <arei.gong...@huawei.com> wrote: > From: Gonglei <arei.gong...@huawei.com> > > fix CID 1311372. > > Signed-off-by: Gonglei <arei.gong...@huawei.com> > --- > hw/arm/xlnx-zynqmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c > index 5e72078..00c5943 100644 > --- a/hw/arm/xlnx-zynqmp.c > +++ b/hw/arm/xlnx-zynqmp.c > @@ -144,7 +144,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error > **errp) > } else { > s->boot_cpu_ptr = &s->apu_cpu[i]; > } > -
Thanks, Please keep this blank line here and below. The g_gree should group with the above code. Otherwise, Reviewed-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> Regards, Peter > + g_free(name); > object_property_set_int(OBJECT(&s->apu_cpu[i]), GIC_BASE_ADDR, > "reset-cbar", &err); > if (err) { > @@ -181,7 +181,7 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error > **errp) > } else { > s->boot_cpu_ptr = &s->rpu_cpu[i]; > } > - > + g_free(name); > object_property_set_bool(OBJECT(&s->rpu_cpu[i]), true, > "reset-hivecs", > &err); > if (err != NULL) { > -- > 1.7.12.4 > > >