On 07/07/2015 10:08, Igor Mammedov wrote: > > Some devices, like IPMI, need to add ACPI table entries to report > > their presence. Add a method for adding these entries. > > I think that it's not up to device to define in which table/scope > it's entries should be but rather upto a board/platform to decide. > > I'd prefer the old way of adding device's ACPI AML into existing > SSDT
This was suggested by Michael, so I think you should read the reviews of earlier versions first. Paolo , like we do for every other device that needs it > (for example: pvpanic). > That allows to keep ACPI code in one place and for each platform > to decide to which table put a device description and where exactly > it should be. > > So I'd drop this patch and add function that returns non NULL > "IPMIFwInfo *" if IPMI device is present and use slightly modified > 15/16 to add device entry into the existing SSDT.