On Sun, Jul 5, 2015 at 1:58 PM, Peter Crosthwaite <peter.crosthwa...@xilinx.com> wrote: > On Sun, Jul 5, 2015 at 1:47 PM, Dmitry Osipenko <dig...@gmail.com> wrote: >> 05.07.2015 23:26, Peter Crosthwaite пишет: >> >>> Hi Dmitry, >>> >>> Based on my comment earlier, this is what I came up with RE consolidation >>> of >>> those arm_mptimer code paths that were giving you problems. I have not >>> done the >>> interrupt mask fix, as that one from your series is reasonably >>> independent. >>> >>> Regards, >>> Peter >>> >>> Peter Crosthwaite (2): >>> timer: arm_mp: Factor out timer value calculation >>> timer: arm_mp: consolidate control and counter write logic >>> >>> hw/timer/arm_mptimer.c | 73 >>> +++++++++++++++++++++++++++++--------------------- >>> 1 file changed, 42 insertions(+), 31 deletions(-) >>> >> >> Hi Peter, thanks a lot! Generally, I don't have any trouble with currently >> missed functionality, just noticed it while was hacking my NVIDIA Tegra2 >> emulation pet-project and decided to contribute =). >> >> It looks like you are trying to duplicate what generic ptimer is already >> doing, isn't it? >> > > Yes, ptimer was probably the correct way to do this in the first > place. Some of the new code structures introduced in this patch series > are directly applicable though for that conversion effort. >
Conversion also comes at the price of a VMSD version bump if Peter is ok with that. Regards, Peter > Regards, > Peter > >> -- >> Dmitry >>
