On 30.04.2010, at 14:48, 乔崇 wrote:

> Hi,everyone!
> I just add AHCI Emulation into qemu.
> I have tested it on linux kernel,it works well.
> run like this:
> qemu -hda disk ...
> 
> Now only support sata disk.


Hi Chong,

While I haven't compiled and tried it out myself, it's amazing to see someone 
did work on this already. We currently have a GSoC project going on to 
implement AHCI, so this seems like an amazing kickstart.

Elek, could you please look over this patch, comment on it and evaluate how 
well it looks? I'll do the same as soon as time permits (on vacation atm).

Chong, at first glace I see some formal issues:

  1) Use the unified diff format for all of the patch / patches (diff -ur or 
git format-patch)
  2) Add a "Signed-off-by: Chong Qiao <qiaoch...@loongson.cn>" line to the 
patch description
  3) Split up the patch for easier review.
  4) Add "[RFC] [PATCH]" to the subject line of the mail


Alex



Reply via email to