On 02/07/2015 11:20, Stefan Hajnoczi wrote: > > Currently, the NVDIMM driver has been merged into upstream Linux Kernel and > > this patchset tries to enable it in virtualization field > > From a device model perspective, have you checked whether it makes sense > to integrate nvdimms into the pc-dimm and hostmem code that is used for > memory hotplug and NUMA? > > The NVDIMM device in your patches is a completely new TYPE_DEVICE so it > doesn't share any interfaces or code with existing memory devices. > Maybe that is the right solution here because NVDIMMs have different > characteristics, but I'm not sure.
The hostmem code should definitely be shared, e.g. by adding a new "file" property to the memory-backend-file class. ivshmem can also use it---CCing Marc-André. I don't know about the pc-dimm devices. If the NVDIMM devices can do _OST and can be hotplugged, then the answer is probably yes. Paolo
