From: Paolo Bonzini <pbonz...@redhat.com> bdrv_close already does that, and in fact hmp_drive_del would need another drain after the flush (which bdrv_close does). So remove the duplication.
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Alberto Garcia <be...@igalia.com> Reviewed-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-id: 1432822629-25401-1-git-send-email-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- blockdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index b354676..4d5e016 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2167,9 +2167,6 @@ void hmp_drive_del(Monitor *mon, const QDict *qdict) return; } - /* quiesce block driver; prevent further io */ - bdrv_drain_all(); - bdrv_flush(bs); bdrv_close(bs); /* if we have a device attached to this BlockDriverState -- 2.4.3