On Fri, Jun 26, 2015 at 02:25:42PM +0200, Laszlo Ersek wrote: > On 06/26/15 11:31, Markus Armbruster wrote: > > Laszlo Ersek <ler...@redhat.com> writes: > > > >> With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: > >> > >> -device isa-fdc,driveA=drive-fdc0-0-0 \ > >> -drive file=...,if=none,id=drive-fdc0-0-0,format=raw > >> > >> then the board-default FDC will be skipped, and only the explicitly > >> requested FDC will exist. qtree-wise, this is correct; however such an FDC > >> is currently not registered in the CMOS, because that code is only reached > >> for the board-default FDC. > >> > >> The pc_cmos_init_late() one-shot reset handler -- one-shot because the > >> CMOS is not reprogrammed during warm reset -- should search for any ISA > >> FDC devices, created implicitly (by board code) or explicitly, and set the > >> CMOS accordingly to the ISA FDC(s) with iobase=0x3f0: > >> > >> - if there is no such FDC, report both drives absent, > >> - if there is exactly one such FDC, report its drives in the CMOS, > >> - if there are more than one such FDCs, then pick one (it is not specified > >> which one), and print a warning about the ambiguity. > >> > >> Cc: Jan Tomko <jto...@redhat.com> > >> Cc: John Snow <js...@redhat.com> > >> Cc: Markus Armbruster <arm...@redhat.com> > >> Cc: Paolo Bonzini <pbonz...@redhat.com> > >> Reported-by: Jan Tomko <jto...@redhat.com> > >> Suggested-by: Markus Armbruster <arm...@redhat.com> > >> Signed-off-by: Laszlo Ersek <ler...@redhat.com> > >> Reviewed-by: John Snow <js...@redhat.com> > > > > Reviewed-by: Markus Armbruster <arm...@redhat.com> > > Thank you. Can you or John please send a PULL req for this? (Or include > it in an upcoming PULL of yours.) > > I've been Cc'ing Paolo because the get-maintainer script reported him at > the top for the patch set, but I believe he might not have time for this > now. > > Thanks! > Laszlo
It's listed as part of PC in MAINTAINERS, but looks like get-maintainer didn't recognize the format. I fixed it up, will review and queue the patches. -- MST
