Hi On Fri, Jun 26, 2015 at 5:53 PM, Andreas Färber <afaer...@suse.de> wrote:
> Please don't use HTML mails, that breaks quoting as you can see below. > > I mostly use gmail, afaik it's multipart, never had issues with that. Am 26.06.2015 um 17:27 schrieb Marc-André Lureau: > > On Fri, Jun 26, 2015 at 5:08 PM, Andreas Färber <afaer...@suse.de > > <mailto:afaer...@suse.de>> wrote: > > > > > > For the second time within days you're posting a patch for something > > that's been on the list already... The commit message above is > entirely > > > > > > Sorry which patch are you refering to? > > This one vs. my http://patchwork.ozlabs.org/patch/336367/ > > And my "[PATCH for-2.3? 0/7] tests: Fix TCG make test" series vs. > your http://patchwork.ozlabs.org/patch/487719/ > See my previous reply. > > > Is it wrong to repost a old patch and adding, while adding signoff and > > modifications? > > (what I just did in this series for David patches) > > "contrib: add ivshmem client and server" looks (formally) okay except > for the final [...], which should go before your Signed-off-by. > Ok, thanks I'll check that. > That's not what you've done here though, as I complained. You did not > ask me about the state of my patch either before you posted this. > I don't see what that changes. You can give the status of your patch now. > > > Tbh, your patch was just launching one instance of qemu with ivshmem. If > you > > look at the one I proposed, you'll notice that it is completely > > different: I don't think your > > signoff or copyright should be added here. > > Well, I disagree. Extending a test case does not give you the right to > replace SUSE with Red Hat. Makes it look like an NIH problem. > It's really a different patch, sorry. > Also, see the discussion on my RFC: CONFIG_LINUX is wrong here. It would > need to depend on KVM/eventfd, and for that there is no easy config > option available here, which stopped my patch at the time. > Right, I don't have good answer for that. I'd need more help. cheers -- Marc-André Lureau
