On Wed, Jun 24, 2015 at 05:56:16PM +0200, Thomas Huth wrote:
> The "-net dump" option only works with the "-net" option. So far, it
> is not possible to dump network traffic with the "-netdev" option yet.
> This patch series now fixes this ugliness by enabling dumping for the
> "-netdev" option, too.
>
> Unlike with my first attempt a couple of weeks ago ("net: Enable vlans
> and dump for -netdev, too"), this patch series now does not "abuse"
> the disliked internal vlan hub infrastructure anymore but introduces
> a new, clean "dumpfile=xxx" option for the -netdev parameters instead.
>
> It's likely too late for version 2.4 for this patch series, but it
> would be great to get some review feedback for this anyway.
>
> Thomas Huth (5):
> net/dump: Add support for receive_iov function
> net/dump: Move DumpState into NetClientState
> net/dump: Rework net-dump init functions
> net/dump: Add dump option for netdev devices
> qemu options: Add information about dumpfile to help text
>
> include/net/net.h | 8 +++++
> net/clients.h | 5 ++++
> net/dump.c | 89
> ++++++++++++++++++++++++++++++++++++-------------------
> net/net.c | 48 ++++++++++++++++++++++++++++++
> qapi-schema.json | 12 ++++++--
> qemu-options.hx | 26 +++++++++++-----
> 6 files changed, 147 insertions(+), 41 deletions(-)Overall this approach looks good, let's do it in QEMU 2.5.
pgpS_u0Vx1w1v.pgp
Description: PGP signature
