On 6 August 2014 at 17:12, Paolo Bonzini <pbonz...@redhat.com> wrote: > From: Sebastian Tanase <sebastian.tan...@openwide.fr> > > Make icount parameter use QemuOpts style options in order > to easily add other suboptions. > > Signed-off-by: Sebastian Tanase <sebastian.tan...@openwide.fr> > Tested-by: Camille Bégué <camille.be...@openwide.fr> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Hi. I've just noticed that this change means we will abort and dump core for user command line errors with icount: $ qemu-system-x86_64 -icount bang qemu-system-x86_64: icount: Invalid shift value Aborted (core dumped) > + configure_icount(icount_opts, &error_abort); ...we shouldn't be using error_abort for situations where the errors could be caused by user input, only where we know that any error must be a bug in QEMU itself. thanks -- PMM
