On 23 June 2015 at 11:30, Stefano Stabellini <stefano.stabell...@eu.citrix.com> wrote: > On Tue, 23 Jun 2015, Peter Maydell wrote: >> I'm afraid I can't apply this -- this revert commit is missing a >> signed-off-by >> line. Can you respin, please? > > I thought that being a straight revert, didn't need a SOB line. > xen-220615-2 is the tag with SOB line on the last commit: > > git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615-2
"xen/pass-through: fold host PCI command register writes" only has Jan's signoff, not yours too... (apologies for not noticing that first time around.) I have a bit in my pull-request-creation script that automatically checks that every commit has my signoff, to avoid this kind of mistake: https://git.linaro.org/people/peter.maydell/misc-scripts.git/blob/HEAD:/make-pullreq#l98 thanks -- PMM