On 11/05/2015 17:26, Stefan Hajnoczi wrote: > + switch (tx_offload) { > + case ROCKER_TX_OFFLOAD_L3_CSUM: > + if (!tlvs[ROCKER_TLV_TX_L3_CSUM_OFF]) { > + return -ROCKER_EINVAL; > + }
Is the fallthrough intentional here? Paolo > + case ROCKER_TX_OFFLOAD_TSO: > + if (!tlvs[ROCKER_TLV_TX_TSO_MSS] || > + !tlvs[ROCKER_TLV_TX_TSO_HDR_LEN]) { > + return -ROCKER_EINVAL; > + } > + } > +