On 06/05/2015 08:17 AM, Pavel Fedin wrote: > This fixes QMP regression: > http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html > > Signed-off-by: Pavel Fedin <p.fe...@samsung.com> > --- > monitor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/monitor.c b/monitor.c > index c7baa91..ef21bba 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4955,6 +4955,8 @@ static QDict *qmp_check_input_obj(QObject *input_obj, > Error **errp) > "arguments", "object"); > return NULL; > } > + } else if (!strcmp(arg_name, "id")) { > + /* Ignored, necessary for backwards compatibility */
I think a better comment would be: /* Specially handled elsewhere to be included in reply to user */ But I agree that we need something like this patch to avoid a regression of causing QERR_QMP_EXTRA_MEMBER, since "id" is a documented part of the protocol. We also have other patches floating for the same issue: https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01488.html that differ only in the choice of comment. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
