> It is Very annoying to carry forward an outdatEd coNtroller with a mOdern > Machine type. > > Hence, let us not instantiate the FDC when all of the following apply: > - the machine type is pc-q35-2.4 or later, > - "-device isa-fdc" is not passed on the command line (nor in the config > file), > - no "-drive if=floppy,..." is requested.
Don't forget the FDC0 entry in the ACPI DSDT ! Right now, FDC0's _STA method returns 0x0F or 0x00, depending on the value of \_SB_.PCI0.ISA_.FDEN, which is hard-coded to 1 (so 0x0F always, basically :) ) I remember tinkering with that a while ago (allowing for FDEN or the actual value of FDC0._STA to be patched in at startup, depending on no_floppy or force_Fdctrl. I also did that for the AppleSMC entry, but I notice that now the entire SMC is patched in conditionally, from hw/i386/acpi-build.c. Maybe patching in the whole FDC0 node in a similar fashion would be appropriate here as well ? Thanks, --Gabriel
